add: related object name to favorite in navigation drawer #8659
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds object type labels to favorites in the navigation drawer, displaying the related object name (e.g. "Company", "Person") next to each favorite item with a bullet point separator.
Key changes:
- Added
objectNameprop toNavigationDrawerItemwith styled container showing "· ObjectName" format - Implemented hover behavior to hide object name when hovering favorite items
- Added
StyledItemObjectNamecomponent with proper styling and text capitalization - Passed
objectNameSingularfrom favorite objects through to navigation components - Fixed display formatting with proper spacing and text overflow handling
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+148
to
+150
| .navigation-drawer-item:hover & { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
logic: Hiding content on hover may cause accessibility issues for keyboard/screen reader users
| </NavigationDrawerAnimatedCollapseWrapper> | ||
| {objectName ? ( | ||
| <StyledItemObjectName> | ||
| {' · '} |
There was a problem hiding this comment.
style: Non-breaking space should be used instead of regular space for better typography
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8549
Screencast.from.2024-11-22.00-35-00.webm