Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for scopeid error #8513

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

FelixMalfait
Copy link
Member

Can't figure out #8347 so I'm adding logs, maybe it'll help debug in the future!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced error logging for scope ID issues by adding more detailed context information when a scope ID is missing or cannot be found in the context.

  • Added Context display name to error message in packages/twenty-front/src/modules/ui/utilities/recoil-scope/scopes-internal/hooks/useAvailableScopeId.ts to help identify which context is failing
  • Added ScopeInternalContext.scopeId value to error message to show the actual value that was attempted to be used
  • Error message now uses template literals for better readability and formatting

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait FelixMalfait enabled auto-merge (squash) November 15, 2024 11:50
@FelixMalfait FelixMalfait merged commit bd18eb8 into main Nov 15, 2024
19 checks passed
@FelixMalfait FelixMalfait deleted the add-loging-for-scopeid-error branch November 15, 2024 13:16
Copy link

sentry-io bot commented Nov 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: crypto.randomUUID is not a function. (In 'crypto.randomUUID()', 'crypto.randomUUID' is undefined) /welcome View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant