Fix remove no result menu from relation picker #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed the "No result" message from the relation picker dropdown menu to improve UX clarity when searches yield no results.
- Simplified empty state handling in
SingleEntitySelectMenuItems.tsxby removing redundant "No result" message display - Modified dropdown menu behavior to only show "Create New" button when no results are found
- Reordered exports in
twenty-ui/src/display/index.tsfor better organization
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Thanks @khuddite for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8455
Summary
Removed redundant
No resultmenu from relation pickerScreenshot
CleanShot.2024-11-13.at.12.08.31.mp4