Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown toggle functionality #8476

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8468

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed dropdown toggle functionality by adding the trigger element reference to the click outside listener, resolving the issue where dropdowns would only open but not close on subsequent clicks.

  • Added refs.domReference to useListenClickOutsideV2 refs array in /packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx to properly detect clicks on trigger element
  • Dropdown now correctly toggles open/closed when clicking the trigger element instead of only opening

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@harshrajeevsingh harshrajeevsingh changed the title fix: toggle close issue fix: dropdown toggle functionality Nov 13, 2024
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit c98a8a2 into twentyhq:main Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown toggle isn't working
2 participants