Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make csv export unavailable when only one record is selected #8409

Merged

Conversation

bosiraphael
Copy link
Contributor

Make csv export unavailable when only one record is selected

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the record action menu to disable CSV export functionality when a single record is selected, while maintaining export capability for multiple records or no selection.

  • Renamed globalRecordActionEffects to noSelectionRecordActionEffects in /packages/twenty-front/src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx for better clarity
  • Moved ExportRecordsActionEffect to only appear in noSelectionRecordActionEffects and multipleRecordActionEffects arrays
  • Simplified action effects rendering by consolidating into a single map operation
  • Removed position calculation offset previously used with globalRecordActionEffects

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@FelixMalfait FelixMalfait merged commit aa27095 into main Nov 8, 2024
18 checks passed
@FelixMalfait FelixMalfait deleted the make-csv-export-unavailable-when-one-record-is-selected branch November 8, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants