Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to specify front port #8382

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Be able to specify front port #8382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31ce890
Be able to specify front port
lucasbordeau Nov 7, 2024
353db4a
Merge branch 'main' into feat/add-front-port-in-en
lucasbordeau Nov 7, 2024
02c674f
Fix
charlesBochet Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/twenty-front/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ REACT_APP_SERVER_BASE_URL=http://localhost:3000
GENERATE_SOURCEMAP=false

# ———————— Optional ————————
# REACT_APP_PORT=3001
# CHROMATIC_PROJECT_TOKEN=
# VITE_DISABLE_TYPESCRIPT_CHECKER=true
# VITE_DISABLE_ESLINT_CHECKER=true
6 changes: 5 additions & 1 deletion packages/twenty-front/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* eslint-disable no-console */
import { isNonEmptyString } from '@sniptt/guards';
import react from '@vitejs/plugin-react-swc';
import wyw from '@wyw-in-js/vite';
import path from 'path';
Expand All @@ -17,8 +18,11 @@ export default defineConfig(({ command, mode }) => {
VITE_BUILD_SOURCEMAP,
VITE_DISABLE_TYPESCRIPT_CHECKER,
VITE_DISABLE_ESLINT_CHECKER,
REACT_APP_PORT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update self-hosting-var + front .env-example

} = env;

const port = isNonEmptyString(REACT_APP_PORT) ? parseInt(REACT_APP_PORT) : 3001;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: parseInt() could return NaN for invalid numbers. Add validation for port range (1-65535) and handle invalid input.


const isBuildCommand = command === 'build';

const tsConfigPath = isBuildCommand
Expand Down Expand Up @@ -61,7 +65,7 @@ export default defineConfig(({ command, mode }) => {
cacheDir: '../../node_modules/.vite/packages/twenty-front',

server: {
port: 3001,
port,
host: 'localhost',
fs: {
allow: [
Expand Down
Loading