Clean available fields in variable dropdown #8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces field filtering logic for the workflow variable dropdown, excluding relation fields and improving fake value generation for workflow testing.
- Fixed inverted logic in
workflow-builder/utils/generate-fake-object-record.tswhereshouldGenerateFieldFakeValuecondition was incorrectly excluding valid fields - Added new utility
shouldGenerateFieldFakeValueinworkflow-builder/utils/should-generate-field-fake-value.tsto filter out system, inactive, and relation fields - Improved type clarity in
workflow/types/Workflow.tsby renaming index signature parameter from 'hello' to 'key'
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
9
to
11
| if (shouldGenerateFieldFakeValue(field)) { | ||
| return acc; | ||
| } |
There was a problem hiding this comment.
logic: Logic is inverted - shouldGenerateFieldFakeValue returns true for fields that SHOULD generate values, but here we're skipping those fields. Remove the ! operator or rename the function to be clearer.
Comment on lines
+6
to
+11
| export const shouldGenerateFieldFakeValue = (field: FieldMetadataEntity) => { | ||
| return ( | ||
| !field.isSystem && | ||
| field.isActive && | ||
| field.type !== FieldMetadataType.RELATION | ||
| ); |
There was a problem hiding this comment.
style: Consider adding null/undefined check for field parameter to prevent runtime errors
martmull
approved these changes
Nov 6, 2024
thomtrp
force-pushed
the
tt-clean-avalable-fields-in-variable-dropdown
branch
from
0392da2
to
2898993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
We do not want relations yet in picker