Fix action menu dropdown #8368
Merged
Fix action menu dropdown #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves action menu dropdown behavior and ID management across the application, focusing on proper click-outside handling and consistent component ID generation.
- Introduces new utility functions (
getActionBarIdFromActionMenuId,getActionMenuDropdownIdFromActionMenuId,getActionMenuIdFromRecordIndexId) in/packages/twenty-front/src/modules/action-menu/utils/to standardize component ID generation - Replaces
useListenClickOutsidewithuseListenClickOutsideV2in/packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsxfor better click-outside event handling - Moves state extraction outside callbacks in hooks like
useRecordBoardSelectionanduseTriggerActionMenuDropdownfor improved performance - Adds proper test coverage for new utility functions in
/packages/twenty-front/src/modules/action-menu/utils/__tests__/ - Uses
useAvailableComponentInstanceIdOrThrowconsistently for component instance context validation
21 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,26 +1,32 @@ | |||
| import { getActionBarIdFromActionMenuId } from '@/action-menu/utils/getActionBarIdFromActionMenuId'; | |||
| import { getActionMenuDropdownIdFromActionMenuId } from '@/action-menu/utils/getActionMenuDropdownIdFromActionMenuId'; | |||
| import { useBottomBar } from '@/ui/layout/bottom-bar/hooks/useBottomBar'; | |||
| import { useDropdownV2 } from '@/ui/layout/dropdown/hooks/useDropdownV2'; | |||
|
|
|||
| export const useActionMenu = (actionMenuId: string) => { | |||
There was a problem hiding this comment.
style: Consider adding type validation for actionMenuId to ensure it's not empty/undefined
Comment on lines
+1
to
+2
| export const getActionMenuIdFromRecordIndexId = (recordIndexId: string) => { | ||
| return `action-menu-record-index-${recordIndexId}`; |
There was a problem hiding this comment.
style: Consider adding input validation to ensure recordIndexId is not empty/undefined
Comment on lines
+39
to
+41
| const isActionBarOpenState = isBottomBarOpenedComponentState.atomFamily({ | ||
| instanceId: getActionBarIdFromActionMenuId(actionMenuInstanceId), | ||
| }); |
There was a problem hiding this comment.
logic: isBottomBarOpenedComponentState.atomFamily is called on every render. Move this outside the component or memoize it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix action menu dropdown not closing when clicking outside the table or board and introduce helper functions to get the action menu component ids.