Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs troubleshooting page #8312

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Nov 4, 2024

Related to #8296

@BOHEUS BOHEUS marked this pull request as draft November 4, 2024 16:48
@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 4, 2024

@Bonapara could you take a look? It's a WIP as I'm starting to check issues and gather all information

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR consolidates troubleshooting documentation from various sources into a dedicated page and makes minor text improvements across the documentation for better clarity and accuracy.

  • Added new /packages/twenty-website/src/content/developers/self-hosting/troubleshooting.mdx with common solutions from Discord help channels
  • Moved troubleshooting sections from local-setup.mdx and docker-compose.mdx to the new dedicated page
  • Fixed file extension references in import-export-data.mdx from .xslx/.xsl to .xlsx/.xls
  • Corrected command examples in README.md to consistently use npx nx instead of just nx
  • Removed erroneous line "Sure, here is the glossary..." from glossary.mdx

11 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@Bonapara
Copy link
Member

Bonapara commented Nov 5, 2024

Looking good to me! I just can't remember if the docs supports H4 (####) did you check?

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 5, 2024

From what I checked, H4 is supported like here

@BOHEUS BOHEUS marked this pull request as ready for review November 8, 2024 17:05
@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 8, 2024

@Bonapara I checked issues from #help channel from last 6 months, didn't see anything special which could be added as most problems are outdated by now, if you think solutions for old problems should be added, let me know

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

Based on the recent changes, I'll provide a summary focusing only on the new modifications not covered in the previous review:

This PR continues to improve documentation clarity and organization with minor but important text corrections across multiple files.

  • Added new /packages/twenty-website/src/content/developers/self-hosting/qa.mdx to address common user questions about integrations, account recovery, and hosting options
  • Updated version-specific URLs in docker-compose.mdx to point to v0.32.0 instead of main branch for better stability
  • Added detailed configuration instructions for external access in docker-compose.mdx
  • Documented Redis connection and JWT token handling changes for v0.32.0 in upgrade-guide.mdx

11 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -45,7 +44,7 @@ Follow these steps for a manual setup.

Copy the example environment file to a new .env file in your working directory:
```bash
curl -o .env https://raw.githubusercontent.com/twentyhq/twenty/main/packages/twenty-docker/.env.example
curl -o .env https://raw.githubusercontent.com/twentyhq/twenty/refs/tags/v0.32.0/packages/twenty-server/.env.example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: URL path should be twenty-docker/.env.example not twenty-server/.env.example

Copy link
Contributor Author

@BOHEUS BOHEUS Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the way link in docker-compose page is presented with tag as it forces to update page every release but this secures from tickets about wrong configuration when changes in environment variables are pushed to repo during sprint, how should it be solved?

Comment on lines +86 to +88
1. **Verify SERVER_URL:**

Ensure `SERVER_URL` in your `.env` file matches your external access URL, including `https` if SSL is enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Add example of correct SERVER_URL format

Comment on lines +92 to +93
- Confirm that your reverse proxy is correctly forwarding requests to the Twenty server.
- Ensure headers like `X-Forwarded-For` and `X-Forwarded-Proto` are properly set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Add example nginx/apache configuration for proper header forwarding

@@ -121,7 +121,9 @@ We have updated the way we handle the Redis connection.

Update your `.env` file to use the new `REDIS_URL` variable instead of the individual Redis connection parameters.

We have also simplifed the way we handle the JWT tokens.
<ArticleEditContent></ArticleEditContent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Empty ArticleEditContent tag appears to serve no purpose here and breaks the flow of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants