Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap in object edition page #8310

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix gap in object edition page #8310

merged 2 commits into from
Nov 4, 2024

Conversation

ijreilly
Copy link
Collaborator

@ijreilly ijreilly commented Nov 4, 2024

Fixing
image

Note - this page design be updated in the next release (#7979)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed visual layout issues in the object edition page by adjusting component spacing and structure in the SettingsDataModelObjectAboutForm.

  • Removed redundant StyledSectionWrapper component to eliminate unwanted spacing
  • Reorganized motion.div and StyledAdvancedSettingsContainer nesting for better layout flow
  • Added margin-top to StyledAdvancedSettingsContainer to maintain proper spacing between form sections

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@ijreilly ijreilly enabled auto-merge (squash) November 4, 2024 16:35
@charlesBochet charlesBochet merged commit 741020f into main Nov 4, 2024
18 of 19 checks passed
@charlesBochet charlesBochet deleted the fix-gap-data-model branch November 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants