fix: dropdown menu doesn't close and remains open #8302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not closing after selection
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses dropdown menu persistence issues by implementing proper closing behavior and consistent dropdown ID management across components.
- Added dropdown cleanup on unmount in
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/MultiItemFieldMenuItem.tsx - Fixed typo in
CurrencyPickerHotkeyScope.tsenum value ('currncy-picker-dropdown-id') - Standardized dropdown ID format to include '-dropdown-id' suffix in
PhoneCountryPickerDropdownButton.tsx - Implemented automatic dropdown closing on mouse leave in
MultiItemFieldMenuItem.tsx - Added closeDropdown call in handleMouseLeave to prevent multiple open dropdowns
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...y-front/src/modules/ui/input/components/internal/currency/types/CurrencyPickerHotkeyScope.ts
Outdated
Show resolved
Hide resolved
lucasbordeau
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Screen.Recording.2024-11-04.at.4.17.02.PM.mov