Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook tests #8260

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix storybook tests #8260

merged 2 commits into from
Oct 31, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Oct 31, 2024

Before
Capture d’écran 2024-10-31 à 16 58 34

After
Capture d’écran 2024-10-31 à 16 58 14

Before
Capture d’écran 2024-10-31 à 16 57 59

After
Capture d’écran 2024-10-31 à 16 57 29

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @thomtrp !

@@ -101,7 +101,10 @@ export const SettingsDataModelFieldRelationForm = ({
});

const selectedObjectMetadataItem = findObjectMetadataItemById(
watchFormValue('relation.objectMetadataId'),
watchFormValue(
'relation.objectMetadataId',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended in this pr @thomtrp ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it fixes the second test

@thomtrp thomtrp merged commit 74291e5 into main Oct 31, 2024
18 checks passed
@thomtrp thomtrp deleted the tt-fix-storybook-tests-2 branch October 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants