-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dropdowns should have a max-height & padding from screen #8055
Conversation
/award 500 |
Awarding harshrajeevsingh: 500 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh |
@FelixMalfait Thanks for your constant support :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you that's nice fix. I have just updated the padding value so it matches figma design
@martmull Thanks for the merge. But due to some recent changes to this component (before raising this PR), I found an issue with this solution. In the attached screencast, you can see that at some point, the dropdown behaves weirdly. Screencast.from.2024-10-29.13-51-57.webm |
@harshrajeevsingh ok thank you for checking that. I will revert that merge and then open a new issue so you can add a proper solution to that issue |
Fixes: #6105
Problem
Solution
DropdownMenu
Screencast.from.2024-10-25.13-47-04.webm