Update install.sh #7973
Merged
Update install.sh #7973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the install.sh script to fetch configuration files based on the specified version, improving version consistency across installations.
- Modified
install.shto use$versioninstead of$branchwhen fetchingdocker-compose.ymland.env.example - Added version detection using GitHub API if not provided as an environment variable
- Introduced potential backwards compatibility issues for installations using older versions
- Removed unused
$branchvariable, which may impact custom installations - Consider adding error handling for failed GitHub API requests or file downloads
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
@charlesBochet @FelixMalfait please this review this PR |
install.sh
Outdated
|
|
||
| # Replace TAG=latest by TAG=<latest_release or version input> | ||
| if [[ $(uname) == "Darwin" ]]; then | ||
| # Running on macOS |
There was a problem hiding this comment.
keep the comments, they are useful here, why remove them?
There was a problem hiding this comment.
Ok I will fix it
install.sh
Outdated
|
|
||
| # Copy twenty/packages/twenty-docker/.env.example to .env | ||
| # Set REDIS_URL or REDIS_HOST depending on the version |
There was a problem hiding this comment.
I think this is because of the current bug we have where the docker-compose is using REDIS_URL but 0.31.x images are still using REDIS_HOST
install.sh
Outdated
| @@ -72,20 +72,18 @@ done | |||
| echo "📁 Creating directory '$dir_name'" | |||
| mkdir -p "$dir_name" && cd "$dir_name" || { echo "❌ Failed to create/access directory '$dir_name'"; exit 1; } | |||
|
|
|||
| # Copy the twenty/packages/twenty-docker/docker-compose.yml file in it | |||
| # Fetch docker-compose.yml from the branch corresponding to the version or main | |||
There was a problem hiding this comment.
I would say same as my comment above
This reverts commit 74fff03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the install.sh script to fetch the docker-compose.yml file from the GitHub branch or tag that matches the version specified by the user, instead of defaulting to the main branch.