Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to twenty-ui - utilities/dimensions #7949

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Migrate to twenty-ui - utilities/dimensions #7949

merged 5 commits into from
Oct 23, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 22, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-7539.


Description

  • Move the utilities/dimensions from twenty-front to twenty-ui and update imports\

Fixes twentyhq/private-issues#79

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request migrates the ComputeNodeDimensions component from the twenty-front package to the twenty-ui package, improving code organization and reusability.

  • Moved ComputeNodeDimensions component to /packages/twenty-ui/src/utilities/dimensions/components/
  • Updated import in /packages/twenty-front/src/modules/ui/input/components/EntityTitleDoubleTextInput.tsx to use the new location
  • Added export for ComputeNodeDimensions in /packages/twenty-ui/src/utilities/index.ts
  • Changed import of isDefined to @ui/utilities in the ComputeNodeDimensions component

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit dcf92ae into main Oct 23, 2024
18 checks passed
@charlesBochet charlesBochet deleted the TWNTY-7539 branch October 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants