Migrate to twenty-ui utilities/screen-size #7836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request moves the useScreenSize hook from the twenty-front package to the twenty-ui package, enhancing its accessibility and reusability across the application.
- Relocated
useScreenSize.tstopackages/twenty-ui/src/utilities/screen-size/hooks/ - Updated import in
packages/twenty-front/src/modules/ui/layout/page/DefaultLayout.tsxto use the new location - Added
useScreenSizeexport inpackages/twenty-ui/src/utilities/index.ts - Verified mobile navigation functionality remains intact on the landing page
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
gitstart-twenty
changed the title
|
@gitstart-twenty could you rebase this one? |
charlesBochet
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: TWNTY-7540.
Description
Move
utilities/screen-sizeto thetwenty-uipackageDemo
The
useScreenSizewas used to render the mobile nav for example on the landing page.It still renders properly
Fixes #7540
Dev QA
utilities/screen-sizeshould be moved to thetwenty-uifolderThe mobile nav should still show on the landing page