Fix GraphQL Api Setters not being applied #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses a critical oversight in the new GraphQL API implementation, reintroducing the FieldGetter logic that was inadvertently omitted during the rebuild.
- Added QueryResultGettersFactory to GraphqlQueryRunnerService in
packages/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-runner.service.ts - Modified executeQuery method to apply getters to query results before returning
- Ensures consistent application of FieldGetter logic across all query results
- Temporary solution until the logic is moved to the ORM level
- Maintains API behavior consistency during the transition to the new GraphQL API structure
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+368
to
+370
| Array.isArray(resultWithGetters) | ||
| ? resultWithGetters | ||
| : [resultWithGetters], |
There was a problem hiding this comment.
style: Consider moving this array check to a separate utility function for better readability and reusability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebuilding the new GraphQLAPI (without pg_graphql), we forgot to include the FieldGetter logic. This logic will soon be moved at ORM level but we will need to keep it there for now
The bug has many impacts such as the fileToken not being generated and preventing users from loading files