Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: droppable-placeholder #7600

Merged

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #7597

This PR fixes the missing placeholder from Droppable component.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a missing placeholder element in the Droppable component of the RecordBoardColumnCardsContainer, resolving issue #7597.

  • Added {droppableProvided.placeholder} to RecordBoardColumnCardsContainer.tsx to fix drag-and-drop functionality
  • Resolves console warning related to the missing placeholder in the Droppable component
  • Improves the overall user experience for drag-and-drop operations in the record board

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet
Copy link
Member

/oss.gg 100

Copy link

oss-gg bot commented Oct 13, 2024

Thanks for opening an issue! It's live on oss.gg!

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit d3e503c into twentyhq:main Oct 13, 2024
11 checks passed
Copy link

oss-gg bot commented Oct 13, 2024

Awarding harshrajeevsingh: 100 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh

Copy link

Thanks @harshrajeevsingh for your contribution!
This marks your 2nd PR on the repo. You're top 17% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Droppable setup issue
2 participants