Refactor action menu #7586
Merged
Refactor action menu #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request refactors the action menu system, introducing new components and modifying existing ones to improve modularity and efficiency. Here's a concise summary of the major changes:
- Introduced new action effect components for managing record actions (DeleteRecordsActionEffect, ExportRecordsActionEffect, ManageFavoritesActionEffect)
- Replaced ActionMenuEntriesProvider with RecordActionMenuEntriesSetter for better management of action menu entries
- Refactored action menu entries storage from an array to a Map for improved efficiency
- Added new hooks and selectors for managing action menu entries (useActionMenuEntries, actionMenuEntriesComponentSelector)
- Modified useObjectMetadataItemById to handle null objectId inputs and return null for not found items
Key points to consider:
- Ensure consistent usage of the new Map structure for action menu entries across the codebase
- Verify that the new action effect components are properly integrated and tested
- Review the changes in useDeleteTableData for potential performance impacts with large datasets
- Consider adding more comprehensive error handling in useRecoilComponentValueV2
25 file(s) reviewed, 30 comment(s)
Edit PR Review Bot Settings | Greptile
...ront/src/modules/action-menu/actions/record-actions/components/DeleteRecordsActionEffect.tsx
Show resolved
Hide resolved
...ront/src/modules/action-menu/actions/record-actions/components/DeleteRecordsActionEffect.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/action-menu/actions/record-actions/components/ExportRecordsActionEffect.tsx
Show resolved
Hide resolved
...ront/src/modules/action-menu/actions/record-actions/components/ExportRecordsActionEffect.tsx
Show resolved
Hide resolved
...ront/src/modules/action-menu/actions/record-actions/components/ExportRecordsActionEffect.tsx
Show resolved
Hide resolved
...s/twenty-front/src/modules/object-metadata/hooks/__tests__/useObjectMetadataItemById.test.ts
Show resolved
Hide resolved
...enty-front/src/modules/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2.ts
Show resolved
Hide resolved
...enty-front/src/modules/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2.ts
Show resolved
Hide resolved
...enty-front/src/modules/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2.ts
Show resolved
Hide resolved
...enty-front/src/modules/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2.ts
Show resolved
Hide resolved
| actionMenuEntriesComponentState, | ||
| ); | ||
|
|
||
| const addActionMenuEntry = (entry: ActionMenuEntry) => { |
There was a problem hiding this comment.
I think we should make more explicit the role of the key in the map
registerActionManuEntries(key, entries[])
|
|
||
| export const SingleRecordActionMenuEntriesSetter = () => { | ||
| const actionEffects = [ | ||
| ExportRecordsActionEffect, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces effects to set the actionMenuEntries