7203 support emails links phones in zapier inputs 2 #7562

martmull · 2024-10-10T13:23:14Z

Done

add EMAILS, PHONES, LINKS, RICH_TEXT, POSITION, and ARRAY field support in Twenty zapier integration
fix twenty-zapier package tests and requirements

Emails

Links

Phones

Array

greptile-apps

PR Summary

This pull request enhances the Twenty Zapier integration by adding support for new field types, including EMAILS, PHONES, LINKS, RICH_TEXT, POSITION, and ARRAY.

Updated computeInputFields.ts to handle new field types, improving type safety with FieldMetadataType enum
Added formatArrayInputData function in handleQueryParams.ts for processing complex array inputs
Expanded FieldMetadataType enum and updated NodeField and InputField types in data.types.ts
Modified test files to cover new field types and their expected behaviors
Added 'dotenv' dependency to package.json for environment variable management

_{8 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2024-10-10T13:25:11Z

packages/twenty-zapier/src/test/utils/computeInputFields.test.ts

+        label: 'Whatsapp: Secondary Lings',
+        type: 'string',
+        helpText: 'Contact’s Whatsapp account: Link Label',


syntax: 'Secondary Lings' is misspelled, should be 'Secondary Links'

greptile-apps · 2024-10-10T13:25:33Z

packages/twenty-zapier/src/test/utils/handleQueryParams.test.ts

+      whatsapp__secondaryLinks: [
+        "{url: '/secondary_whatsapp_url',label: 'Secondary Whatsapp Link'}",
+      ],


logic: The whatsapp__secondaryLinks array contains a string instead of an object. This might cause issues when parsing the data.

greptile-apps · 2024-10-10T13:25:33Z

packages/twenty-zapier/src/test/utils/handleQueryParams.test.ts

+      phones: {
+        primaryPhoneNumber: '322110011',
+        primaryPhoneCountryCode: '+33',
+        additionalPhones: ["{ phoneNumber: '322110012', countryCode: '+33' }"],


logic: The additionalPhones array contains a string representation of an object instead of an actual object. This might lead to parsing issues.

greptile-apps · 2024-10-10T13:25:34Z

packages/twenty-zapier/src/test/utils/handleQueryParams.test.ts

      'domainName: "Company Domain Name", ' +
      'linkedinUrl: {url: "/linkedin_url", label: "Test linkedinUrl"}, ' +
+      'whatsapp: {primaryLinkUrl: "/whatsapp_url", primaryLinkLabel: "Whatsapp Link", secondaryLinks: [{url: \'/secondary_whatsapp_url\',label: \'Secondary Whatsapp Link\'}]}, ' +


style: The expected result for whatsapp.secondaryLinks contains escaped single quotes. Ensure this matches the actual output of handleQueryParams.

greptile-apps · 2024-10-10T13:25:34Z

packages/twenty-zapier/src/test/utils/handleQueryParams.test.ts

      'domainName: "Company Domain Name", ' +
      'linkedinUrl: {url: "/linkedin_url", label: "Test linkedinUrl"}, ' +
+      'whatsapp: {primaryLinkUrl: "/whatsapp_url", primaryLinkLabel: "Whatsapp Link", secondaryLinks: [{url: \'/secondary_whatsapp_url\',label: \'Secondary Whatsapp Link\'}]}, ' +
+      'emails: {primaryEmail: "[email protected]", additionalEmails: ["[email protected]"]}, ' +
+      'phones: {primaryPhoneNumber: "322110011", primaryPhoneCountryCode: "+33", additionalPhones: [{ phoneNumber: \'322110012\', countryCode: \'+33\' }]}, ' +


style: The expected result for phones.additionalPhones contains an object literal without quotes. Verify if this matches the actual output of handleQueryParams.

greptile-apps · 2024-10-10T13:26:24Z

packages/twenty-zapier/src/utils/computeInputFields.ts

@@ -141,6 +148,84 @@ const get_subfieldsFromField = (nodeField: NodeField): NodeField[] => {
      };
      return [address1, address2, city, state, postalCode, country];
    }
+    case FieldMetadataType.PHONES: {


style: The structure for PHONES is more complex than other fields. Consider extracting this into a separate function for better readability

greptile-apps · 2024-10-10T13:27:09Z

packages/twenty-zapier/src/utils/handleQueryParams.ts

@@ -1,5 +1,17 @@
 import { InputData } from '../utils/data.types';

+const OBJECT_SUBFIELD_NAMES = ['secondaryLinks', 'additionalPhones'];


style: Consider using a more descriptive name for OBJECT_SUBFIELD_NAMES, such as ARRAY_OBJECT_SUBFIELD_NAMES, to better reflect its purpose

greptile-apps · 2024-10-10T13:27:09Z

packages/twenty-zapier/src/utils/handleQueryParams.ts

+    if (Array.isArray(formattedInputData[key])) {
+      result = result.concat(
+        `${key}: [${formatArrayInputData(key, formattedInputData)}], `,
+      );


logic: Ensure that formatArrayInputData is called with the correct arguments. The second argument should be formattedInputData[key], not the entire formattedInputData object

greptile-apps · 2024-10-10T13:27:28Z

packages/twenty-zapier/tsconfig.json

+    "**/*.spec.ts",
+    "**/*.test.ts",
+    "**/*.spec.tsx",
+    "**/*.test.tsx",


style: Consider using a single pattern '**/*.{spec,test}.{ts,tsx}' to cover all test files

charlesBochet

LGTM!

## Done - add `EMAILS`, `PHONES`, `LINKS`, `RICH_TEXT`, `POSITION`, and `ARRAY` field support in Twenty zapier integration - fix `twenty-zapier` package tests and requirements ## Emails <img width="791" alt="image" src="https://github.com/user-attachments/assets/7987a1a2-6076-4715-9221-d4a1898b7634"> ## Links <img width="797" alt="image" src="https://github.com/user-attachments/assets/b94ce972-fae2-4953-b9e8-79c0478f5f60"> ## Phones <img width="789" alt="image" src="https://github.com/user-attachments/assets/7234eaaf-40b8-4772-8880-c58ba47618c5"> ## Array <img width="834" alt="image" src="https://github.com/user-attachments/assets/99cb6795-e428-40ea-9c3a-d52561c2c6e1">

martmull added 4 commits October 10, 2024 11:23

Fix testing

3a3b03d

Update computeInputFields

165fc0b

Add dotenv in zapier app

0d94652

Update computeInputFields

e2df8d9

martmull linked an issue Oct 10, 2024 that may be closed by this pull request

Support EMAILS, LINKS, PHONES in Zapier Inputs #7203

Closed

martmull marked this pull request as ready for review October 10, 2024 13:23

greptile-apps bot reviewed Oct 10, 2024

View reviewed changes

charlesBochet approved these changes Oct 10, 2024

View reviewed changes

charlesBochet assigned martmull Oct 10, 2024

martmull merged commit 29bd74f into main Oct 10, 2024
5 checks passed

martmull deleted the 7203-support-emails-links-phones-in-zapier-inputs-2 branch October 10, 2024 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7203 support emails links phones in zapier inputs 2 #7562

7203 support emails links phones in zapier inputs 2 #7562

martmull commented Oct 10, 2024

greptile-apps bot left a comment

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

greptile-apps bot Oct 10, 2024

charlesBochet left a comment

		@@ -1,5 +1,17 @@
		import { InputData } from '../utils/data.types';

		const OBJECT_SUBFIELD_NAMES = ['secondaryLinks', 'additionalPhones'];

7203 support emails links phones in zapier inputs 2 #7562

7203 support emails links phones in zapier inputs 2 #7562

Conversation

martmull commented Oct 10, 2024

Done

Emails

Links

Phones

Array

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 10, 2024

Choose a reason for hiding this comment

charlesBochet left a comment

Choose a reason for hiding this comment