Fix settings navigation advanced design #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request focuses on improving the settings navigation design by adjusting layout and positioning of various components. Key changes include:
- Removed logic that moved existing elements and added the settings icon to an absolute position in
SettingsNavigationDrawerItems.tsx - Adjusted the
marginLeftcalculation inDefaultLayout.tsxfor the settings page, potentially making it slightly wider - Modified
AdvancedSettingsToggle.tsxto use relative and absolute positioning for better layout control - Updated
NavigationDrawer.tsxto improve responsiveness and animation logic for drawer width - Removed left margin from
NavigationDrawerBackButton.tsxto align with new positioning - Removed fixed width from
NavigationDrawerSection.tsxfor more flexible layout
These changes collectively aim to create a more consistent and visually appealing settings navigation experience.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
50
to
58
| const StyledIconContainer = styled.div` | ||
| border-right: 1px solid ${MAIN_COLORS.yellow}; | ||
| display: flex; | ||
| margin-top: ${({ theme }) => theme.spacing(5)}; | ||
| width: 16px; | ||
| position: absolute; | ||
| left: ${({ theme }) => theme.spacing(-5)}; | ||
| margin-top: ${({ theme }) => theme.spacing(2)}; | ||
| height: 90%; | ||
| `; |
There was a problem hiding this comment.
style: The StyledIconContainer is now positioned absolutely. Ensure this doesn't cause layout issues in different viewport sizes.
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
This PR moved the settings navigation to the left and bottom twentyhq#7130 Updating the logic to: -remove logic that move the existing -add the setting icon to absolute <img width="264" alt="Capture d’écran 2024-10-07 à 18 04 05" src="https://github.com/user-attachments/assets/b848a5dd-50e9-48c2-bb50-1dcffa9481ac"> <img width="264" alt="Capture d’écran 2024-10-07 à 18 04 11" src="https://github.com/user-attachments/assets/3812929c-dce0-410b-8caa-3ea1210af958">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moved the settings navigation to the left and bottom #7130
Updating the logic to:
-remove logic that move the existing
-add the setting icon to absolute