Fix: Adjust chevron alignment to the right edge #7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adjusts the alignment of chevron icons in the webhook and API keys tables, addressing the issue described in #7403.
- Modified
SettingsDevelopersWebhookTableRow.tsxto use a more flexible grid layout for better chevron alignment - Updated
SettingsApiKeysFieldItemTableRow.tsxandSettingsApiKeysTable.tsxto set a fixed 24px width for the chevron column - Adjusted padding in
SettingsDevelopersWebhookTableRow.tsxto position the chevron 4px from the right edge - Removed unused React import in
SettingsDevelopersWebhookTableRow.tsxfor code cleanliness
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ehconitin
reviewed
Oct 7, 2024
...twenty-front/src/modules/settings/developers/components/SettingsApiKeysFieldItemTableRow.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 7, 2024
packages/twenty-front/src/modules/settings/developers/components/SettingsApiKeysTable.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 7, 2024
...wenty-front/src/modules/settings/developers/components/SettingsDevelopersWebhookTableRow.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 7, 2024
ehconitin
approved these changes
Oct 8, 2024
|
Awarding Vardhaman619: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Vardhaman619 |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
This pull request addresses the alignment issue of the chevron icon, ensuring that it is positioned correctly on the right edge. Fixes [twentyhq#7403](twentyhq#7403)  --------- Co-authored-by: Charles Bochet <[email protected]> Co-authored-by: ehconitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the alignment issue of the chevron icon, ensuring that it is positioned correctly on the right edge.
Fixes #7403