fix: overflow issue in tableSection #7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an overflow issue in the TableSection component, fixing the visibility problem for object fields described in issue #7327.
- Changed
overflow: hiddentooverflow-y: autoin StyledSection component to enable vertical scrolling - Modification allows all fields to be visible when content exceeds max-height
- Directly resolves issue Only the first 29 object fields are visible/editable #7327 where only the first 29 object fields were visible/editable
- Minor reordering of imports, which doesn't affect functionality
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/ui/layout/table/components/TableSection.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 3, 2024
packages/twenty-front/src/modules/ui/layout/table/components/TableSection.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 3, 2024
packages/twenty-front/src/modules/ui/layout/table/components/TableSection.tsx
Outdated
Show resolved
Hide resolved
ehconitin
reviewed
Oct 3, 2024
packages/twenty-front/src/modules/ui/layout/table/components/TableSection.tsx
Outdated
Show resolved
Hide resolved
ehconitin
approved these changes
Oct 8, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
this PR fixes twentyhq#7327 --------- Co-authored-by: ehconitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #7327