Update README.md with Hacktoberfest banner #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacktoberfest
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a Hacktoberfest banner to the README.md file, enhancing visual appeal and promoting participation in the event.
- Added responsive Hacktoberfest banner image at the top of README.md
- Banner uses
<picture>element for dark/light mode compatibility - Link to "oss.gg" added, but URL may need verification
- Image alt text "Hacktoberfest" added for accessibility
- Consider adjusting banner size or placement for better integration with existing content
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
README.md
Outdated
| @@ -1,3 +1,12 @@ | |||
| <p align="center"> | |||
| <a href="oss.gg"> | |||
There was a problem hiding this comment.
logic: The link 'oss.gg' appears to be incomplete or incorrect. Consider using a full URL or checking if this is the intended destination.
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://github.com/twentyhq/twenty/blob/33be2dbbe14eea00445010ecb9cd53ed603c01d5/packages/twenty-website/public/images/readme/Github%20Read-me%20banner.png"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://github.com/twentyhq/twenty/blob/33be2dbbe14eea00445010ecb9cd53ed603c01d5/packages/twenty-website/public/images/readme/Github%20Read-me%20banner.png"> | ||
| <img src="./packages/twenty-website/public/images/readme/Github%20Read-me%20banner.png" alt="Hacktoberfest" /> |
There was a problem hiding this comment.
style: The 'alt' attribute 'Hacktoberfest' doesn't provide enough context. Consider a more descriptive alt text like 'Hacktoberfest banner for Twenty CRM'.
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Hacktoberfest banner on readme! --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hacktoberfest banner on readme!