Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Toggle not visible in light mode #7322

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

harshit078
Copy link
Contributor

Note

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the visibility issue of the Toggle component in light mode by modifying its background color when in the "off" state.

  • Changed background color in StyledContainer from theme.background.quaternary to theme.background.invertedSecondary for improved contrast
  • Modification affects the Toggle component used across the application, including in data model field options
  • Fix aims to resolve issue Select in Data model > Object > date field details in dark mode isn't clearly visible #7321, enhancing visibility in both dark and light modes
  • No changes to component functionality or structure, focusing solely on visual improvement

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Bonapara
Copy link
Member

Thanks for raising this PR @harshit078!

You're right, the visibility is poor in Dark mode, but we should address it differently. Keep the toggle background set to "Transparent/Medium," but change the button color to gray/10. (Gray/10 is a primitive color, meaning it will remain #FCFCFC in both light and dark modes)

Illustration:

image

image

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FelixMalfait FelixMalfait merged commit 8350e7d into twentyhq:main Oct 3, 2024
3 of 8 checks passed
Copy link

github-actions bot commented Oct 3, 2024

Thanks @harshit078 for your contribution!
This marks your 21st PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

harshit078 added a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
> [!Note]
> - This PR solves the issue twentyhq#7321 
> - Added a minor fix in color background of toggle

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants