Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code #6611

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Remove some dead code #6611

merged 1 commit into from
Aug 11, 2024

Conversation

FelixMalfait
Copy link
Member

We could remove a lot more than this, this is just a start.

There are various tools to help with this, knip is a good one

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request focuses on removing dead code to clean up the codebase and reduce maintenance overhead.

  • Removed ActivityBodyEffect.tsx: Ensure no dependencies on this Recoil state management component.
  • Deleted activityTitleFamilyState.ts: Verify that the family state for activity titles is not used elsewhere.
  • Removed targetableObjectsInDrawerState.ts: Confirm that this Recoil atom is not referenced in other parts of the codebase.
  • Deleted CommentChip.tsx and related stories: Ensure no UI elements or functionality depend on the CommentChip component.
  • Modified import statements and type declarations: Minor changes in various input components to correct imports and clean up type exports.

30 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait FelixMalfait force-pushed the remove-dead-code branch 3 times, most recently from b0b70e7 to cf8be99 Compare August 11, 2024 17:22
@FelixMalfait FelixMalfait merged commit d5350e1 into main Aug 11, 2024
13 of 14 checks passed
@FelixMalfait FelixMalfait deleted the remove-dead-code branch August 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant