Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bool fields editable again #6551

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Aug 6, 2024

As title

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request reintroduces editability for boolean fields in the record table and inline cell components, enhancing user interaction with these fields.

  • Implemented useIsFieldReadOnly hook in RecordInlineCell.tsx to dynamically determine field read-only status
  • Modified RecordTableCellFieldInput.tsx to use useIsFieldReadOnly hook instead of hardcoded read-only value
  • Updated RecordInlineCell.tsx to combine readonly prop with useIsFieldReadOnly result for more flexible control
  • Reordered import statements in RecordInlineCell.tsx for better code organization

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Weiko Weiko merged commit 67c4125 into main Aug 6, 2024
7 of 13 checks passed
@Weiko Weiko deleted the tt-make-bool-fields-editable-again branch August 6, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants