Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): twenty-e2e-testing with playwright #6539

Merged
merged 11 commits into from
Aug 14, 2024

Conversation

Nabhag8848
Copy link
Contributor

@Nabhag8848 Nabhag8848 commented Aug 5, 2024

ISSUE (e2e) - Introduces e2e for twenty

Description

  • Create Package.
  • Setup environments such as baseUrl.
  • ignore CI configuration for now.
  • write a simple test to check if table is visible in companies tab.

Running test with UI

yarn run test:e2e:ui
Screen.Recording.2024-08-05.at.5.57.09.PM.mov

Running all test and seeing report

yarn run test:e2e
yarn run test:e2e:report
Screen.Recording.2024-08-05.at.5.58.26.PM.mov

@Nabhag8848 Nabhag8848 marked this pull request as ready for review August 5, 2024 12:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Introduced end-to-end (E2E) testing for the twenty project using Playwright, enhancing the testing capabilities and ensuring application stability.

  • package.json: Added twenty-e2e-testing package to the monorepo for E2E testing.
  • packages/twenty-e2e-testing/.env.example: Introduced environment variable configuration for E2E tests.
  • packages/twenty-e2e-testing/README.md: Provided detailed instructions for running E2E tests.
  • packages/twenty-e2e-testing/e2e/companies.spec.ts: Added a basic test to verify table visibility on the /objects/companies page.
  • packages/twenty-e2e-testing/playwright.config.ts: Configured Playwright for E2E testing, including browser setups and parallel execution.

6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@@ -0,0 +1,2 @@
# Note that provide always without trailing forward slash to have expected behaviour
FRONTEND_BASE_URL="http://localhost:3001"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Add a newline at the end of the file to follow best practices for text files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks doing lesss goo

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Aug 5, 2024

@lucasbordeau I have few more questions before we can review this.

  • What all major browsers we need to configure ?
  • what about mobile viewports ? if we need this rn, can you provide more details, will add.
  • Do we need to include this in documentation, it will be, can you point out how we are adding docs - example of it ? , which will help me also to change Readme as per our standards

@lucasbordeau
Copy link
Contributor

@Nabhag8848 Thanks, nice work.

  • Chrome is ok for now
  • No need to cover mobile viewport for now, we'll see later
  • We'll see for documentation later

@lucasbordeau
Copy link
Contributor

You can let Firefox and Safari as they're already here.

@Nabhag8848
Copy link
Contributor Author

Nabhag8848 commented Aug 13, 2024

@lucasbordeau made changes 🔥, lemme know if we need any more changes. also we can work next on #4832 or on adding CI config, whichever has P0 priority.

@lucasbordeau
Copy link
Contributor

@Nabhag8848 Could you please check the problem with yarn and the CI ? It seems to be related to the packages you installed.

@Nabhag8848
Copy link
Contributor Author

@lucasbordeau

@lucasbordeau lucasbordeau self-assigned this Aug 14, 2024
Copy link
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thank you.

@lucasbordeau lucasbordeau merged commit 197bca5 into twentyhq:main Aug 14, 2024
1 of 2 checks passed
Copy link

Thanks @Nabhag8848 for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@BOHEUS BOHEUS mentioned this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup E2E testing
3 participants