Fix domainName seeds #6454
Merged
Fix domainName seeds #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The domainNamePrimaryLinkUrl property in companies.ts has been simplified from an object to a string.
- Modified
packages/twenty-server/src/database/typeorm-seeds/workspace/companies.tsto changedomainNamePrimaryLinkUrlfrom an object to a string. - Ensure dependent code is updated to handle the new string format.
- Test the seeding process to confirm compatibility with the new data structure.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -42,7 +42,7 @@ export const seedCompanies = async ( | |||
| { | |||
| id: DEV_SEED_COMPANY_IDS.LINKEDIN, | |||
| name: 'Linkedin', | |||
| domainNamePrimaryLinkUrl: { primarlyLinkUrl: 'https://linkedin.com' }, | |||
| domainNamePrimaryLinkUrl: 'https://linkedin.com', | |||
There was a problem hiding this comment.
style: Ensure all dependent code is updated to handle the new string format for domainNamePrimaryLinkUrl.
| @@ -54,7 +54,7 @@ export const seedCompanies = async ( | |||
| { | |||
| id: DEV_SEED_COMPANY_IDS.FACEBOOK, | |||
| name: 'Facebook', | |||
| domainNamePrimaryLinkUrl: { primarlyLinkUrl: 'https://facebook.com' }, | |||
| domainNamePrimaryLinkUrl: 'https://facebook.com', | |||
There was a problem hiding this comment.
check: Verify that the seeding process works correctly with the updated domainNamePrimaryLinkUrl format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.