Fixes CI post merge #6435
Merged
Fixes CI post merge #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request focuses on fixing CI issues post-merge by refining import statements and updating utility functions for better code organization.
- Modified
packages/twenty-front/src/pages/settings/serverless-functions/__stories__/SettingsServerlessFunctionDetail.stories.tsxto reorder import statements. - Updated import paths for utilities in the same file.
- Replaced
getImageAbsoluteURIOrBase64withgetImageAbsoluteURIfor improved clarity and maintainability.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Jul 29, 2024
martmull
approved these changes
Jul 29, 2024
|
The sb-performance crash is caused by Linaria which slows down stories loading : #6437 We'll investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CI problems post merge of #6282
CI often crashes because some TS files aren't included during development and developers push errors on their PR.
Created an issue to mitigate this : #6436