Handle query runner errors #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomtrp
commented
Jul 26, 2024
thomtrp
commented
- Throw service error from query runner
- Catch in resolver factories
- Map to graphql errors
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces comprehensive error handling improvements for the query runner, ensuring service-specific exceptions are mapped to GraphQL errors.
- Enhanced Error Handling: Replaced generic exceptions with
WorkspaceQueryRunnerExceptionacross multiple files for more granular error control. - New Utility Function: Added
workspace-query-runner-graphql-api-exception-handler.util.tsto map custom exceptions to GraphQL errors. - Custom Exception Class: Introduced
workspace-query-runner.exception.tsto standardize error handling within the workspace query runner. - Resolver Updates: Modified resolver factories to catch and handle errors using the new exception handler utility.
- GraphQL Config Update: Replaced
useExceptionHandlerwithuseGraphQLErrorHandlerHookingraphql-config.service.tsfor improved error handling.
16 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -49,7 +58,7 @@ export const computePgGraphQLError = ( | |||
| const errorMessage = error?.message; | |||
|
|
|||
| const mappedErrorKey = Object.keys(pgGraphQLErrorMapping).find( | |||
| (key) => errorMessage?.startsWith(key), | |||
| (key) => errorMessage?.contains(key), | |||
There was a problem hiding this comment.
Style: Use of contains instead of startsWith for error message matching.
thomtrp
changed the title
charlesBochet
changed the title
charlesBochet
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.