Fix: query runner orm #6397
Merged
Fix: query runner orm #6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request focuses on refactoring the WorkspaceQueryRunnerService to utilize TwentyORMGlobalManager for database operations, enhancing maintainability and reducing technical debt.
- Refactored
workspace-query-runner.service.ts: IntegratedTwentyORMGlobalManagerfor CRUD operations, replacing custom methods. - Removed Methods:
handleDeleteWorkspaceMemberandhandleDeleteBlocklistItemmethods were removed. - Updated
workspace-datasource.factory.ts: Simplified cache version logic using the nullish coalescing operator (??=).
Ensure thorough testing to validate ORM integration and edge case handling.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -546,19 +590,9 @@ export class WorkspaceQueryRunnerService { | |||
| options, | |||
| ); | |||
|
|
|||
| // TODO START: remove this awful patch and use our upcoming custom ORM is developed | |||
| const deletedWorkspaceMember = await this.handleDeleteWorkspaceMember( | |||
There was a problem hiding this comment.
Great that you tackled this!
We can also delete the code for those functions, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WorkspaceQueryRunner events using TwentyORM
Fix #6057