Forbid default value nullification for non-nullable field #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added validation to prevent nullification of default values for non-nullable fields (
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts) - Introduced utility function
assertDoesNotNullifyDefaultValueForNonNullableField(packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/assert-does-not-nullify-default-value-for-non-nullable-field.util.ts) - Integrated new utility function into
updateOnemethod (packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts) - Added but did not utilize private method
nullifiesDefaultValueForNonNullableField(packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts)
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Removed
nullifiesDefaultValueForNonNullableFieldmethod (packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts) - Integrated
assertDoesNotNullifyDefaultValueForNonNullableFieldutility function for validation - Ensured non-nullable fields' default values cannot be set to null during updates
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Jul 15, 2024
| FieldMetadataExceptionCode, | ||
| } from 'src/engine/metadata-modules/field-metadata/field-metadata.exception'; | ||
|
|
||
| export const assertDoesNotNullifyDefaultValueForNonNullableField = ({ |
There was a problem hiding this comment.
can we add a unit test on this util?
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added unit tests in
packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/__tests__/assert-does-not-nullify-default-value-for-non-nullable-field.spec.ts - Modified validation logic in
packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/assert-does-not-nullify-default-value-for-non-nullable-field.util.tsto enforce non-nullable field constraints
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title
Enregistrement.de.l.ecran.2024-07-15.a.12.07.45.mov