Add option to synchronize all active workspaces at once #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
--sync-all-active-workspacesoption in/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command.ts - Introduced
isWorkspaceActiveutility in/packages/twenty-server/src/database/commands/utils/is-workspace-active.utils.ts - Refactored workspace activity check in
/packages/twenty-server/src/database/commands/0-22-add-new-address-field-to-views-with-deprecated-address.command.ts - Updated module imports in
/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module.tsto support new feature
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Enhanced
sync-workspace-metadata.command.tsto support synchronizing all active workspaces. - Improved error handling and logging for bulk workspace synchronization.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -81,7 +76,11 @@ export class AddNewAddressFieldToViewsWithDeprecatedAddressFieldCommand extends | |||
| const activeWorkspaceIds = ( | |||
| await Promise.all( | |||
| workspaces.map(async (workspace) => { | |||
| const isActive = await this.workspaceIsActive(workspace); | |||
| const isActive = await isWorkspaceActive({ | |||
There was a problem hiding this comment.
move to workspace.service.ts
| const workspaceIds = options.workspaceId ? [options.workspaceId] : []; | ||
| let workspaceIds = options.workspaceId ? [options.workspaceId] : []; | ||
|
|
||
| if (options.syncAllActiveWorkspaces && isEmpty(workspaceIds)) { |
There was a problem hiding this comment.
no need for onlyActiveWorkspaces
| const activeWorkspaceIds = ( | ||
| await Promise.all( | ||
| workspaces.map(async (workspace) => { | ||
| const isActive = await isWorkspaceActive({ |
There was a problem hiding this comment.
add areWorkspaceActive query
| ); | ||
| } | ||
| } catch (error) { | ||
| if (options.syncAllActiveWorkspaces) { |
There was a problem hiding this comment.
if (options.throwOnFirstFail)
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
getActiveWorkspaceIdsmethod inworkspace.service.tsto fetch active workspace IDs - Updated
sync-workspace-metadata.command.tsto synchronize all active workspaces - Replaced direct repository access with
WorkspaceServicein0-22-add-new-address-field-to-views-with-deprecated-address.command.ts - Removed
is-workspace-active.utils.tsfile - Updated
workspace.service.tsconstructor to includeBillingSubscriptionandFeatureFlagEntityrepositories
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Replaced
WorkspaceServicewithWorkspaceStatusServiceinpackages/twenty-server/src/database/commands/0-22-add-new-address-field-to-views-with-deprecated-address.command.ts - Removed
getActiveWorkspaceIdsmethod frompackages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts - Added
WorkspaceStatusModuletopackages/twenty-server/src/engine/workspace-manager/workspace-manager.module.ts - Introduced
WorkspaceStatusServiceinpackages/twenty-server/src/engine/workspace-manager/workspace-status/services/workspace-status.service.ts - Added option to synchronize all active workspaces in
packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command.ts
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+28
to
+29
| const workspaces = await this.workspaceRepository.find(); | ||
| const workspaceIds = workspaces.map((workspace) => workspace.id); |
There was a problem hiding this comment.
🪶 style: Fetching all workspaces without any filters could be inefficient for large datasets. Consider adding pagination or filtering.
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Corrected import path for
WorkspaceStatusModuleinpackages/twenty-server/src/engine/workspace-manager/workspace-manager.module.ts - Renamed
workspace-manager.module.tstoworkspace-status.module.tsinpackages/twenty-server/src/engine/workspace-manager/workspace-status/ - Updated imports to include
TypeOrmModulewithWorkspace,BillingSubscription, andFeatureFlagEntityentities inworkspace-status.module.ts - Ensured
WorkspaceStatusServiceis provided inworkspace-status.module.ts
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ijreilly
force-pushed
the
sync-metadata-active-workspaces
branch
from
a0ad08c
to
abcf8e6
Compare
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
WorkspaceStatusModuletodatabase-command.module.tsimports - Enhanced
sync-workspace-metadata.command.tsto sync all active workspaces usingWorkspaceStatusService - Improved error handling and logging in
sync-workspace-metadata.command.ts - Added
WorkspaceStatusModuleand removed unnecessary imports inworkspace-sync-metadata-commands.module.ts
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced check for 'IS_BILLING_ENABLED' in
workspace-status.service.tsto filter active workspaces by billing status. - Added
EnvironmentModuletoWorkspaceStatusModuleimports inworkspace-manager.module.ts. - Enhanced
sync-workspace-metadata.command.tsto sync all active workspaces if no specific ID is provided. - Improved logging and error handling in
sync-workspace-metadata.command.ts.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the longer term, we want to improve the efficiency and reliability of the sync-metadata command, by choosing an error handling strategy and paying greater attention to health checks.
In the meantime, this PR adds an option to run the sync-metadata command on all active workspaces at once.