Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove featureFlag on connectedAccount.handleAliases #6202

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

charlesBochet
Copy link
Member

Removing the gating on connectedAccount handleAlias as the feature has been tested for a week

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed feature flag gating on handleAliases field in packages/twenty-server/src/modules/connected-account/standard-objects/connected-account.workspace-entity.ts
  • Deleted import statement for feature flag keys
  • Removed WorkspaceGate decorator from handleAliases field

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesBochet charlesBochet merged commit b14918c into main Jul 10, 2024
6 checks passed
@charlesBochet charlesBochet deleted the remove-gating-on-handle-aliases branch July 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants