AAU I want to re-order my views with drag & drop #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: v1b3m <[email protected]> Co-authored-by: Matheus <[email protected]> Co-authored-by: FellipeMTX <[email protected]>
|
@gitstart-twenty The INDEX view (the one with the lock) should not be draggable, it should always stay at the bottom of the list: |
| [updateView, viewsOnCurrentObject], | ||
| ); | ||
|
|
||
| const getSortedViews = () => { |
There was a problem hiding this comment.
we should not recode this logic. It's already in: getObjectMetadataItemViews function
| key={view.id} | ||
| draggableId={view.id} | ||
| index={index} | ||
| isDragDisabled={viewsOnCurrentObject.length === 1} |
There was a problem hiding this comment.
if it's the INDEX view too
There was a problem hiding this comment.
Hey @charlesBochet
This has been updated!
Co-authored-by: v1b3m <[email protected]> Co-authored-by: Matheus <[email protected]> Co-authored-by: FellipeMTX <[email protected]>
|
LGTM! Thank you! |
charlesBochet
approved these changes
May 15, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
### Description I want to re-order my views with drag & drop ### Refs twentyhq#4782 ### Demo https://jam.dev/c/699ece8a-0467-494a-b9a3-faf666ee9c93 Fixes twentyhq#4782 --------- Co-authored-by: gitstart-twenty <[email protected]> Co-authored-by: v1b3m <[email protected]> Co-authored-by: Matheus <[email protected]> Co-authored-by: FellipeMTX <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to re-order my views with drag & drop
Refs
#4782
Demo
https://jam.dev/c/699ece8a-0467-494a-b9a3-faf666ee9c93
Fixes #4782