Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocknote #3517

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

brendanlaschke
Copy link
Contributor

Update blocknote and remove feature flag as the problems with images described here were fixed.

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brendanlaschke, LGTM :)

@charlesBochet charlesBochet self-assigned this Jan 18, 2024
@charlesBochet charlesBochet merged commit f6f4e6c into twentyhq:main Jan 18, 2024
10 checks passed
@charlesBochet
Copy link
Member

@brendanlaschke I have actually reverted the version upgrade as it was breaking the design and I have opened an issue here, hopefully this can be fixed soon: TypeCellOS/BlockNote#523

@brendanlaschke
Copy link
Contributor Author

oh that's not that great didn't check for this - I thought this are the same styles as for the inline modules before ...

@charlesBochet
Copy link
Member

@brendanlaschke it should be fixed, could you try to re-upgrade blocknote version? :)

@brendanlaschke
Copy link
Contributor Author

It still doesn't look right especially the box sizing is a problem ... but also styles on the body like line height and font-size are breaking the layout ...

Bildschirmfoto 2024-01-22 um 13 31 09

@brendanlaschke brendanlaschke deleted the update-blocknote branch February 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants