Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Switcher - Default Icon Display #6947

Closed
Bonapara opened this issue Sep 9, 2024 · 5 comments · Fixed by #7029
Closed

View Switcher - Default Icon Display #6947

Bonapara opened this issue Sep 9, 2024 · 5 comments · Fixed by #7029
Assignees
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 9, 2024

Current behavior

If not customized, The view icon is set to the Kanban or Table icon. But the icon displayed in the Icon Picker doesn't reflect this. (It displayed the last icon selected in the picker, and by default the list icon)

CleanShot.2024-09-09.at.11.47.52.mp4

Desired Behavior

The picker should display the Table icon by default. If the icon hasn't been edited, the picker should reflect the default icon (Table or Kanban) until the user takes control and chooses a custom icon.

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short labels Sep 9, 2024
@Nabhag8848
Copy link
Contributor

working on it @Bonapara

@Bonapara
Copy link
Member Author

Bonapara commented Sep 9, 2024

Thanks @Nabhag8848!

@rathodvinod5
Copy link
Contributor

@Bonapara, I have resolved this bug, could you please assign it to me so that I can raise a PR?

@Nabhag8848
Copy link
Contributor

hey @rathodvinod5 make the PR. thanks :)

@Nabhag8848 Nabhag8848 removed their assignment Sep 14, 2024
@rathodvinod5
Copy link
Contributor

@Nabhag8848, Thanks.

lucasbordeau added a commit that referenced this issue Oct 10, 2024
Fixes #6947 (View switcher default icon display)

---------

Co-authored-by: Lucas Bordeau <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 10, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
Fixes twentyhq#6947 (View switcher default icon display)

---------

Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants