-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter on array and jsonb field types #6784
Comments
We are still waiting on full pg_graphql deprecation to move forward on this one! |
Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6784 |
@gitstart-twenty to work on this issue you currently need the IsQueryRunnerTwentyORMEnabled feature flag to be enable on your workspace We have introduced new resolvers that do not use pg_graphql (pg_graphql does not support filter on Array fields / jsonb fields) Please reach out to @Weiko to prepare this ticket if needed |
@lucasbordeau fyi |
@ijreilly @gitstart-twenty while investigating this last week, it seems that these types are already present in the graphql schema, not sure they are applied by the graphql-api-runner though |
@charlesBochet I've tried on main and indeed the API exposes some filters already but they are not implemented (or broken). Some are missing as well (in the schema). See screenshots below. Json Filter
Array FiltercontainsFilter, containsAnyFilter, notContains are self explanatory. Those are exposed via the API already but the filter is not implemented when building the ORM query so they will throw an error. Backend implementationCheck |
This PR was created by [GitStart](https://gitstart.com/) to address the requirements from this ticket: [TWNTY-6784](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6784). This ticket was imported from: [TWNTY-6784](#6784) --- ### Description - Add filter on array and jsonb field types - We did not implement the contains any filter for arrays on the frontend because we would need to change the UI design since this should be an array of values, and now we have only one input ### Demo <https://www.loom.com/share/0facf752b63f4120b5d4ea4ee9772d35?sid=d7bde469-e6a9-4298-a637-d81d40695a86> Fixes #6784 --------- Co-authored-by: gitstart-twenty <[email protected]> Co-authored-by: gitstart-twenty <[email protected]> Co-authored-by: Weiko <[email protected]>
Scope & Context
So far we had left out the possibility to filter on field types involving jsonB and array columns (ex: Links, Emails...).
It is now doable thanks to the recent work that replaced pg_graphql (@Weiko ).
Let's introduce filter features for these fields !
The text was updated successfully, but these errors were encountered: