test: improve utils coverage

packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerDeleteRecordsOptimisticEffect.ts

@@ -38,7 +38,7 @@ export const triggerDeleteRecordsOptimisticEffect = ({
 
         const rootQueryCachedObjectRecordConnection = rootQueryCachedResponse;
 
-        const { fieldArguments: rootQueryVariables } =
+        const { fieldVariables: rootQueryVariables } =
           parseApolloStoreFieldName<CachedObjectRecordQueryVariables>(
             storeFieldName,
           );

packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerUpdateRecordOptimisticEffect.ts

@@ -56,7 +56,7 @@ export const triggerUpdateRecordOptimisticEffect = ({
 
         const rootQueryConnection = rootQueryCachedResponse;
 
-        const { fieldArguments: rootQueryVariables } =
+        const { fieldVariables: rootQueryVariables } =
           parseApolloStoreFieldName<CachedObjectRecordQueryVariables>(
             storeFieldName,
           );

packages/twenty-front/src/modules/apollo/services/apollo.factory.ts

@@ -14,7 +14,7 @@ import { createUploadLink } from 'apollo-upload-client';
 
 import { renewToken } from '@/auth/services/AuthService';
 import { AuthTokenPair } from '~/generated/graphql';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 import { logDebug } from '~/utils/logDebug';
 
 import { ApolloManager } from '../types/apolloManager.interface';
@@ -139,7 +139,7 @@ export class ApolloFactory<TCacheShape> implements ApolloManager<TCacheShape> {
           isDebugMode ? logger : null,
           retryLink,
           httpLink,
-        ].filter(assertNotNull),
+        ].filter(isDefined),
       );
     };
 

packages/twenty-front/src/modules/favorites/utils/mapFavorites.ts

@@ -1,5 +1,4 @@
 import { getLogoUrlFromDomainName } from '~/utils';
-import { assertNotNull } from '~/utils/assert';
 import { isDefined } from '~/utils/isDefined';
 
 export const mapFavorites = (favorites: any) => {
@@ -33,6 +32,6 @@ export const mapFavorites = (favorites: any) => {
         position: favorite?.position,
       };
     })
-    .filter(assertNotNull)
+    .filter(isDefined)
     .sort((a: any, b: any) => a.position - b.position);
 };

packages/twenty-front/src/modules/object-record/record-board/states/selectors/recordBoardColumnsFamilySelectorScopeMap.ts

@@ -5,7 +5,7 @@ import { recordBoardColumnsFamilyStateScopeMap } from '@/object-record/record-bo
 import { RecordBoardColumnDefinition } from '@/object-record/record-board/types/RecordBoardColumnDefinition';
 import { createFamilySelectorScopeMap } from '@/ui/utilities/recoil-scope/utils/createFamilySelectorScopeMap';
 import { guardRecoilDefaultValue } from '@/ui/utilities/recoil-scope/utils/guardRecoilDefaultValue';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 export const recordBoardColumnsFamilySelectorScopeMap =
   createFamilySelectorScopeMap<RecordBoardColumnDefinition | undefined, string>(
@@ -57,7 +57,7 @@ export const recordBoardColumnsFamilySelectorScopeMap =
                 }),
               );
             })
-            .filter(assertNotNull);
+            .filter(isDefined);
 
           const lastColumn = [...columns].sort(
             (a, b) => b.position - a.position,

packages/twenty-front/src/modules/object-record/record-field/utils/isFieldValueEmpty.ts

@@ -17,9 +17,9 @@ import { isFieldSelect } from '@/object-record/record-field/types/guards/isField
 import { isFieldSelectValue } from '@/object-record/record-field/types/guards/isFieldSelectValue';
 import { isFieldText } from '@/object-record/record-field/types/guards/isFieldText';
 import { isFieldUuid } from '@/object-record/record-field/types/guards/isFieldUuid';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
-const isValueEmpty = (value: unknown) => !assertNotNull(value) || value === '';
+const isValueEmpty = (value: unknown) => !isDefined(value) || value === '';
 
 export const isFieldValueEmpty = ({
   fieldDefinition,
@@ -46,7 +46,7 @@ export const isFieldValueEmpty = ({
   }
 
   if (isFieldSelect(fieldDefinition)) {
-    return isFieldSelectValue(fieldValue) && !assertNotNull(fieldValue);
+    return isFieldSelectValue(fieldValue) && !isDefined(fieldValue);
   }
 
   if (isFieldCurrency(fieldDefinition)) {

packages/twenty-front/src/modules/object-record/relation-picker/components/SingleEntitySelectMenuItems.tsx

@@ -13,7 +13,7 @@ import { SelectableList } from '@/ui/layout/selectable-list/components/Selectabl
 import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem';
 import { MenuItemSelect } from '@/ui/navigation/menu-item/components/MenuItemSelect';
 import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 import { EntityForSelect } from '../types/EntityForSelect';
 import { RelationPickerHotkeyScope } from '../types/RelationPickerHotkeyScope';
@@ -55,7 +55,7 @@ export const SingleEntitySelectMenuItems = ({
 
   const entitiesInDropdown = [selectedEntity, ...entitiesToSelect].filter(
     (entity): entity is EntityForSelect =>
-      assertNotNull(entity) && isNonEmptyString(entity.name),
+      isDefined(entity) && isNonEmptyString(entity.name),
   );
 
   useScopedHotkeys(

packages/twenty-front/src/modules/search/hooks/useFilteredSearchEntityQuery.ts

@@ -9,7 +9,7 @@ import { EntityForSelect } from '@/object-record/relation-picker/types/EntityFor
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { makeAndFilterVariables } from '@/object-record/utils/makeAndFilterVariables';
 import { makeOrFilterVariables } from '@/object-record/utils/makeOrFilterVariables';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 type SearchFilter = { fieldNames: string[]; filter: string | number };
 
@@ -102,15 +102,11 @@ export const useFilteredSearchEntityQuery = ({
     });
 
   return {
-    selectedEntities: selectedRecords
-      .map(mappingFunction)
-      .filter(assertNotNull),
+    selectedEntities: selectedRecords.map(mappingFunction).filter(isDefined),
     filteredSelectedEntities: filteredSelectedRecords
       .map(mappingFunction)
-      .filter(assertNotNull),
-    entitiesToSelect: recordsToSelect
-      .map(mappingFunction)
-      .filter(assertNotNull),
+      .filter(isDefined),
+    entitiesToSelect: recordsToSelect.map(mappingFunction).filter(isDefined),
     loading:
       recordsToSelectLoading ||
       filteredSelectedRecordsLoading ||

packages/twenty-front/src/modules/settings/data-model/hooks/useFieldPreviewValue.ts

@@ -1,6 +1,6 @@
 import { useObjectNameSingularFromPlural } from '@/object-metadata/hooks/useObjectNameSingularFromPlural';
 import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 export const useFieldPreviewValue = ({
   fieldName,
@@ -21,7 +21,7 @@ export const useFieldPreviewValue = ({
   });
 
   const firstRecordWithValue = records.find(
-    (record) => assertNotNull(record[fieldName]) && record[fieldName] !== '',
+    (record) => isDefined(record[fieldName]) && record[fieldName] !== '',
   );
 
   return {

packages/twenty-front/src/modules/spreadsheet-import/steps/components/MatchColumnsStep/components/UserTableColumn.tsx

@@ -1,7 +1,7 @@
 import styled from '@emotion/styled';
 
 import { RawData } from '@/spreadsheet-import/types';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 import { Column } from '../MatchColumnsStep';
 
@@ -39,7 +39,7 @@ export const UserTableColumn = <T extends string>({
   entries,
 }: UserTableColumnProps<T>) => {
   const { header } = column;
-  const entry = entries.find(assertNotNull);
+  const entry = entries.find(isDefined);
 
   return (
     <StyledContainer>

packages/twenty-front/src/modules/views/components/ViewsDropdownButton.tsx

@@ -20,7 +20,7 @@ import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
 import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
 import { VIEWS_DROPDOWN_ID } from '@/views/constants/ViewsDropdownId';
 import { useViewBar } from '@/views/hooks/useViewBar';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
 
@@ -161,7 +161,7 @@ export const ViewsDropdownButton = ({
                           handleDeleteViewButtonClick(event, view.id),
                       }
                     : null,
-                ].filter(assertNotNull)}
+                ].filter(isDefined)}
                 onClick={() => handleViewSelect(view.id)}
                 LeftIcon={IconList}
                 text={view.name}

packages/twenty-front/src/modules/views/hooks/internal/useFiltersFromQueryParams.ts

@@ -14,7 +14,7 @@ import { useGenerateFindManyRecordsQuery } from '@/object-record/hooks/useGenera
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { ViewFilter } from '@/views/types/ViewFilter';
 import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 const filterQueryParamsSchema = z.object({
   filter: z.record(
@@ -142,7 +142,7 @@ export const useFiltersFromQueryParams = () => {
               },
             ),
           )
-        ).filter(assertNotNull);
+        ).filter(isDefined);
       },
     [
       apolloClient,

packages/twenty-front/src/modules/views/hooks/useViewBar.ts

@@ -7,8 +7,8 @@ import { useAvailableScopeIdOrThrow } from '@/ui/utilities/recoil-scope/scopes-i
 import { ViewField } from '@/views/types/ViewField';
 import { ViewFilter } from '@/views/types/ViewFilter';
 import { ViewSort } from '@/views/types/ViewSort';
-import { assertNotNull } from '~/utils/assert';
 import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
+import { isDefined } from '~/utils/isDefined';
 
 import { ViewScopeInternalContext } from '../scopes/scope-internal-context/ViewScopeInternalContext';
 import { currentViewFieldsScopedFamilyState } from '../states/currentViewFieldsScopedFamilyState';
@@ -116,9 +116,7 @@ export const useViewBar = (props?: UseViewProps) => {
           return;
         }
 
-        const queriedViewFields = viewFields
-          .map((viewField) => viewField)
-          .filter(assertNotNull);
+        const queriedViewFields = viewFields.filter(isDefined);
 
         if (isPersistingView) {
           return;
@@ -173,7 +171,7 @@ export const useViewBar = (props?: UseViewProps) => {
               definition: availableFilterDefinition,
             };
           })
-          .filter(assertNotNull);
+          .filter(isDefined);
 
         if (!isDeeplyEqual(savedViewFilters, queriedViewFilters)) {
           set(savedViewFiltersState, queriedViewFilters);
@@ -220,7 +218,7 @@ export const useViewBar = (props?: UseViewProps) => {
               definition: availableSortDefinition,
             };
           })
-          .filter(assertNotNull);
+          .filter(isDefined);
 
         if (!isDeeplyEqual(savedViewSorts, queriedViewSorts)) {
           set(savedViewSortsState, queriedViewSorts);

packages/twenty-front/src/modules/views/utils/mapViewFieldsToBoardFieldDefinitions.ts

@@ -1,6 +1,6 @@
 import { BoardFieldDefinition } from '@/object-record/record-board-deprecated/types/BoardFieldDefinition';
 import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 import { ViewField } from '../types/ViewField';
 
@@ -28,5 +28,5 @@ export const mapViewFieldsToBoardFieldDefinitions = (
           }
         : null;
     })
-    .filter(assertNotNull);
+    .filter(isDefined);
 };

packages/twenty-front/src/modules/views/utils/mapViewFieldsToColumnDefinitions.ts

@@ -2,7 +2,7 @@ import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata'
 import { ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
 import { mapArrayToObject } from '~/utils/array/mapArrayToObject';
 import { moveArrayItem } from '~/utils/array/moveArrayItem';
-import { assertNotNull } from '~/utils/assert';
+import { isDefined } from '~/utils/isDefined';
 
 import { ViewField } from '../types/ViewField';
 
@@ -48,7 +48,7 @@ export const mapViewFieldsToColumnDefinitions = ({
         viewFieldId: viewField.id,
       };
     })
-    .filter(assertNotNull);
+    .filter(isDefined);
 
   // No label identifier set for this object
   if (!labelIdentifierFieldMetadataId) return columnDefinitionsFromViewFields;

packages/twenty-front/src/utils/__tests__/parseApolloStoreFieldName.test.ts

@@ -0,0 +1,30 @@
+import { parseApolloStoreFieldName } from '../parseApolloStoreFieldName';
+
+describe('parseApolloStoreFieldName', () => {
+  it('returns an empty object if string is not a valid store field name', () => {
+    const result = parseApolloStoreFieldName('////');
+    expect(result).toEqual({});
+  });
+
+  it('returns the field name and parsed variables if they exist', () => {
+    const result = parseApolloStoreFieldName('fieldName({"key":"value"})');
+    expect(result).toEqual({
+      fieldName: 'fieldName',
+      fieldVariables: { key: 'value' },
+    });
+  });
+
+  it('returns only the field name if the variables cannot be parsed', () => {
+    const result = parseApolloStoreFieldName('fieldName(notJson)');
+    expect(result).toEqual({
+      fieldName: 'fieldName',
+    });
+  });
+
+  it('returns only the field name if there are no variables', () => {
+    const result = parseApolloStoreFieldName('fieldName');
+    expect(result).toEqual({
+      fieldName: 'fieldName',
+    });
+  });
+});

packages/twenty-front/src/utils/__tests__/sort.test.ts

@@ -0,0 +1,35 @@
+import { sortAsc, sortDesc, sortNullsFirst, sortNullsLast } from '../sort';
+
+describe('sort', () => {
+  describe('sortNullsFirst', () => {
+    it('should sort nulls first', () => {
+      expect(sortNullsFirst(null, 'a')).toBe(-1);
+      expect(sortNullsFirst('a', null)).toBe(1);
+      expect(sortNullsFirst('a', 'a')).toBe(0);
+    });
+  });
+
+  describe('sortNullsLast', () => {
+    it('should sort nulls last', () => {
+      expect(sortNullsLast(null, 'a')).toBe(1);
+      expect(sortNullsLast('a', null)).toBe(-1);
+      expect(sortNullsLast('a', 'a')).toBe(0);
+    });
+  });
+
+  describe('sortAsc', () => {
+    it('should sort in ascending order', () => {
+      expect(sortAsc('a', 'b')).toBe(-1);
+      expect(sortAsc('b', 'a')).toBe(1);
+      expect(sortAsc('a', 'a')).toBe(0);
+    });
+  });
+
+  describe('sortDesc', () => {
+    it('should sort in descending order', () => {
+      expect(sortDesc('a', 'b')).toBe(1);
+      expect(sortDesc('b', 'a')).toBe(-1);
+      expect(sortDesc('a', 'a')).toBe(0);
+    });
+  });
+});

packages/twenty-front/src/utils/array/__tests__/groupArrayItemsBy.test.ts

@@ -0,0 +1,25 @@
+import { groupArrayItemsBy } from '../groupArrayItemsBy';
+
+describe('groupArrayItemsBy', () => {
+  it('groups an array of objects by a computed key', () => {
+    // Given
+    const array = [
+      { id: '1', type: 'fruit', value: 'apple' },
+      { id: '2', type: 'fruit', value: 'banana' },
+      { id: '3', type: 'vegetable', value: 'carrot' },
+    ];
+    const computeGroupKey = ({ type }: (typeof array)[0]) => type;
+
+    // When
+    const result = groupArrayItemsBy(array, computeGroupKey);
+
+    // Then
+    expect(result).toEqual({
+      fruit: [
+        { id: '1', type: 'fruit', value: 'apple' },
+        { id: '2', type: 'fruit', value: 'banana' },
+      ],
+      vegetable: [{ id: '3', type: 'vegetable', value: 'carrot' }],
+    });
+  });
+});