Skip to content

Commit

Permalink
feat: set primary link in Links field (#5429)
Browse files Browse the repository at this point in the history
Closes #5375

<img width="381" alt="image"
src="https://github.com/twentyhq/twenty/assets/3098428/d87773df-c685-466b-ae35-a8349f79df48">

_____

~~Note that I ugraded `@apollo/client` to v3.10.4 because current
version is causing an error when trying to write the Links field in the
cache in `updateRecordFromCache` (`TypeError: Cannot convert object to
primitive value`). After upgrade, the error is gone but console still
prints a warning (here the custom object name is `Listing` and the Links
field name is `website`):~~

<img width="964" alt="image"
src="https://github.com/twentyhq/twenty/assets/3098428/834b8909-e8dc-464a-8c5a-6b7e4c964a7f">

~~It might be because the Links field seems to somehow have a
`__typename` property in Apollo's cache, so Apollo considers it as a
record and tries to match the object's cache with an id, but the Links
field value has no id so it can't find it.
We might want to find where this `__typename` is added and remove it
from the Links object in the cache.~~

Edit: will fix this in another PR as upgrading `@apollo/client` +
`apollo-upload-client` seems to break types and/or tests. Related issue:
[#5437](#5437)

followup

followup

followup
  • Loading branch information
thaisguigon authored and Weiko committed May 31, 2024
1 parent f0142a2 commit 55f1186
Show file tree
Hide file tree
Showing 19 changed files with 428 additions and 516 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 55f1186

Please sign in to comment.