Fixed restrictive URL sanity check #6570 (#6575)

Fixes #6570 ## Changes - Replaced the old regex with a new, more inclusive regex pattern. - Updated the isURL function to use the new pattern. --------- Co-authored-by: Weiko <[email protected]>
twentyhq · Aug 9, 2024 · 13d05d8 · 13d05d8
1 parent bdac4c8
commit 13d05d8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 79 deletions.
diff --git a/...ges/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhooksNew.tsx b/...ges/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhooksNew.tsx
@@ -12,7 +12,6 @@ import { TextInput } from '@/ui/input/components/TextInput';
 import { SubMenuTopBarContainer } from '@/ui/layout/page/SubMenuTopBarContainer';
 import { Section } from '@/ui/layout/section/components/Section';
 import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
-import { isURL } from '~/utils/is-url';
 
 export const SettingsDevelopersWebhooksNew = () => {
   const navigate = useNavigate();
@@ -23,18 +22,10 @@ export const SettingsDevelopersWebhooksNew = () => {
     targetUrl: '',
     operation: '*.*',
   });
-  const [errorMessage, setErrorMessage] = useState<string | undefined>();
   const { createOneRecord: createOneWebhook } = useCreateOneRecord<Webhook>({
     objectNameSingular: CoreObjectNameSingular.Webhook,
   });
   const handleSave = async () => {
-    setErrorMessage(undefined);
-
-    if (!isURL(formValues.targetUrl)) {
-      setErrorMessage('Invalid webhook URL');
-      return;
-    }
-
     const newWebhook = await createOneWebhook?.(formValues);
 
     if (!newWebhook) {
@@ -80,7 +71,6 @@ export const SettingsDevelopersWebhooksNew = () => {
                 targetUrl: value,
               }));
             }}
-            error={errorMessage}
             fullWidth
           />
         </Section>

diff --git a/packages/twenty-front/src/utils/__tests__/is-url.test.ts b/packages/twenty-front/src/utils/__tests__/is-url.test.ts
diff --git a/packages/twenty-front/src/utils/is-url.ts b/packages/twenty-front/src/utils/is-url.ts