Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Purpose of this Pull Request
This PR is to add tests for the Tween.onRepeat callback.
Details of the changes
I add the following tests. This test follows current onRepeat implementation.
Confirmation
I found that onRepeat behaves differently from GSAP. This difference appears when we set delay or repeatDelay.
GSAP : onRepeat is called just before the tween finishes, waits for a delay, and then plays the next repeat.
tween.js : onRepeat is called just after the tween finishes, before waiting for the delay.
onRepeat by gsap
onRepeat by tween.js
I wrote a codepen on this confirmation. Repeat count on the screen is increased by onRepeat. You can see that the timing at which the repeat count changes is different for each sample.
Is this difference as per specifications? Or is it a bug?
I will keep this PR in draft form until this point is confirmed.