Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary newlines and indentation #724

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

nbacquey
Copy link
Member

@nbacquey nbacquey commented Sep 4, 2024

Description

This PR removes newlines and indentation in function definitions, and when functions are used in last-argument continuations.

Closes #660

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

@nbacquey nbacquey added the language: ocaml OCaml formatting issues label Sep 4, 2024
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I did notice a double indent (see comments)...but maybe this is unavoidable.

topiary-cli/tests/samples/expected/ocaml.ml Outdated Show resolved Hide resolved
@nbacquey nbacquey merged commit 1720fa9 into main Sep 5, 2024
9 checks passed
@nbacquey nbacquey deleted the nb/ocaml_indentation branch September 5, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language: ocaml OCaml formatting issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More dangling functions
2 participants