Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User configuration file #505

Closed
ErinvanderVeen opened this issue Jun 13, 2023 Discussed in #504 · 2 comments · Fixed by #506
Closed

User configuration file #505

ErinvanderVeen opened this issue Jun 13, 2023 Discussed in #504 · 2 comments · Fixed by #506
Labels
good first issue Good for newcomers P2 major: an upcoming release type: feature request

Comments

@ErinvanderVeen
Copy link
Collaborator

Proposed as a solution to #504

Right now, the only way to configure the indentation is through the compile-time languages.toml file (which can be considered a regression from #448). We have always intended to also load a configuration file from XDG_CONFIG/topiary/languages.toml, but no issue existed. This issue serves as that.
@ErinvanderVeen ErinvanderVeen added good first issue Good for newcomers P2 major: an upcoming release type: feature request labels Jun 13, 2023
@toastal
Copy link

toastal commented Jun 13, 2023

What about looking at $PWD/.topiary/languages or similar if a project wants different indentation from the “defaults”? While noted as maybe not the route this project wants to go, reading from the $PWD/.editorconfig could be an option as well to not have conflicting values.

@ErinvanderVeen
Copy link
Collaborator Author

$PWD/.topiary/languages is a good idea. The .editorconfig is something we might consider in the future if we have capacity to maintain a second configuration specification.

@ErinvanderVeen ErinvanderVeen mentioned this issue Jun 13, 2023
Merged
2 tasks
@ErinvanderVeen ErinvanderVeen linked a pull request Jun 13, 2023 that will close this issue
Read user defined configuration file from $ROOT/.topiary/languages.toml #506
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P2 major: an upcoming release type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read user defined configuration file from $ROOT/.topiary/languages.toml tweag/topiary
2 participants
@toastal @ErinvanderVeen