Read user defined configuration file from $ROOT/.topiary/languages.toml #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
June 14, 2023 09:26
The content of this file is then merged with the default one
ErinvanderVeen
force-pushed
the
505-user-configuration-file
branch
from
4f357d3
to
d24e2d9
Compare
ErinvanderVeen
force-pushed
the
505-user-configuration-file
branch
4 times, most recently
from
c6543ee
to
8b46b80
Compare
ErinvanderVeen
force-pushed
the
505-user-configuration-file
branch
from
8b46b80
to
1c8b4ee
Compare
nbacquey
approved these changes
Jun 14, 2023
|
Shouldn't these new file locations be mentioned in the |
|
Yes, of course! I'll make a quick follow-up PR. |
|
#512 followup with documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #505
This would allow users to define custom options.
This PR splits parsing of the configuration file into 2 parts. The first is parsing to toml::Value, this makes it easier to merge the values of multiple configuration files. From there it is
try_intoto ourConfiguration.The
default_configuration(2 functions) have been made part of the topiary crate itself. Other functions, like the one that reads from.topiary/languages.tomlis part of the topiary-cli crate, which gets a newconfigurationmodule.Remaining tasks:
$XDG_CONFIG/.topiary/languages.toml