Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bzlmod python fix #1888

Merged
merged 2 commits into from
Apr 28, 2023
Merged

bzlmod python fix #1888

merged 2 commits into from
Apr 28, 2023

Conversation

ylecornec
Copy link
Member

This PR:

  • Fixes one more python import statement, which refers to a repository name which changes with bzlmod.
  • Makes use of raw strings for regular expressions in some python scripts, to fix invalid escape sequence warnings.

@ylecornec
Fix invalid escape sequence warnings in python scripts
4de8f47
@ylecornec
Fix python import in ldd_test.bzl
3134769 
The `rules_haskell` prefix of the import corresponds to a directory name which is mangled when bzlmod is activated.
@ylecornec ylecornec requested a review from avdv as a code owner April 28, 2023 06:38
@ylecornec ylecornec mentioned this pull request Apr 28, 2023
Closed
14 tasks
avdv
avdv approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ylecornec ylecornec added the merge-queue merge on green CI label Apr 28, 2023
@mergify mergify bot merged commit a43cf06 into master Apr 28, 2023
@mergify mergify bot deleted the ylecornec/bzlmod_python_fix branch April 28, 2023 11:33
@mergify mergify bot removed the merge-queue merge on green CI label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylecornec @avdv