Bzlmod prerequisites #1885
Merged
Bzlmod prerequisites #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With bzlmod workspace_root can now contain tilde symbols
With bzlmod, stringified labels contain non predictable workspace names. Here is should be fine to ignore the workspace name for `os` and `cpu` constraints (which should always be `@platform`) and rely only on the name of the label.
The rules_python prefix corresponds to the folder of the external repository which can change with bzlmod.
ylecornec
force-pushed
the
ylecornec/prepare_bzlmod
branch
from
c8f39d8 to
8373615
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some changes in preparation for bzlmod support.
Repository rules
Under
bzlmodrepository rules cannot register toolchains (this has to be done in theMODULE.bazelfile). So some of them are updated with an extraregisterparameter to optionally disable the registration.Workspace names
Under
bzlmodfolders for external repositories have a different (mangled) name. So these changes were needed:In the following directive
from rules_python.python.runfiles import runfiles, therules_pythonprefix corresponds to the repository folder which can now have a different name. But thepythonmodule can be accessed directly (See rules_python example)These mangled repository names includes tilde symbols so this case was added to the
_zencodefunction.The
platform_of_constraintsfunction was comparing stringified labels which contain these non predictable workspace names. So it was modified to only use label names.