Test bazel test //... in all configurations
#1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are targets that require dynamic libraries to build which are not available in profiling mode.
Do not limit the wildcard to //tests/... or the build to --build_tests_only. Set --build_tag_filters in profiling tests, --test_tag_filters only affects test execution but not builds. Take //... expansion on Windows into account
|
Why was it like this before? Are we assuming it's because of the tests that fail in some configurations? |
Historical reasons. The nixpkgs pipelines existed first and the bindist pipelines were only introduced later and only incrementally. Some parts still require Nix provided tools that have no replacement in the bindist toolchains, e.g. sphinx in |
Radvendii
approved these changes
Jul 19, 2021
Requires manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1553 (comment) and #1553 (comment)
bazel test //...was previously not fully tested in all configurations. The nixpkgs pipelines only testedbazel test //... --build_tests_onlyand the bindist configurations only testedbazel test //tests/.... This PR changes this so that all configurations and the coverage tests usebazel test //.... This required adding exclusion tags to some targets that don't work in all configurations.