Invoke a runghc for the execution platform in the cabal_wrapper #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/runghc
branch
from
5c2a480 to
64e01f3
Compare
aherrmann
reviewed
Mar 16, 2021
There was a problem hiding this comment.
On Windows this fails with
runghc2.exe: C:\users\runneradmin\_bazel_runneradmin\z5des2pa\execroot\YOUR_PROJECT_NAME_HERE\bazel-out\host\bin\external\rules_haskell\haskell\ghc-stage2.exe: rawSystem: does not exist (No such file or directory)
I suspect the issue is that ctx.actions.symlink creates a copy instead of a symlink on Windows. (Symlinks not being available on Windows by default). runghc then tries to find GHC relative to itself and can't. One way to work around this would be to not create a symlink but a wrapper script that calls runghc. That will require two rules: One to generate the source file for the script and one sh_binary that makes the script executable.
facundominguez
force-pushed
the
fd/runghc
branch
2 times, most recently
from
7d1c741 to
12d2fd6
Compare
facundominguez
force-pushed
the
fd/runghc
branch
from
8f8854c to
1dcce54
Compare
facundominguez
commented
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR cabal_wrapper always uses a runghc binary from a toolchain that targets the execution platform. Otherwise, there would be no way to execute Setup.hs when cross-compiling.